Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API-1250] Do not allow different item types in Compact array fields #21958

Merged
merged 5 commits into from
Aug 15, 2022
Merged

[API-1250] Do not allow different item types in Compact array fields #21958

merged 5 commits into from
Aug 15, 2022

Conversation

mdumandag
Copy link
Contributor

The team decided that we wouldn't allow different item types/schemas
in the Compact array fields.

This PR adds the necessary checks to the array of Compact
and array of GenericRecord object fields

@mdumandag mdumandag added Team: Client Source: Internal PR or issue was opened by an employee Module: Serialization Add to Release Notes All Languages Should Check Used by clients team to track fixes on the java client that should potentially backported to others labels Aug 12, 2022
@mdumandag mdumandag added this to the 5.2 milestone Aug 12, 2022
@mdumandag mdumandag self-assigned this Aug 12, 2022
@mdumandag mdumandag requested a review from a team as a code owner August 12, 2022 13:28
This was referenced Aug 12, 2022
Closed
Closed
Closed
Open
Closed
@hz-devops-test
Copy link

The job Hazelcast-pr-builder of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file 
--------------------------
-------TEST FAILURE-------
--------------------------
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   QueueDestroyTest.checkStatsMapEntryRemovedWhenQueueDestroyed:78 expected:<0> but was:<1>
[INFO] 
[ERROR] Tests run: 50717, Failures: 1, Errors: 0, Skipped: 238
[INFO] 

[ERROR] There are test failures.

@mdumandag
Copy link
Contributor Author

Unrelated test failure already reported on #21696

@mdumandag
Copy link
Contributor Author

run-lab-run

@mdumandag
Do not allow different item types in Compact array fields
2260d35 
The team decided that we wouldn't allow different item types/schemas
in the Compact array fields.

This PR adds the necessary checks to the array of Compact
and array of GenericRecord object fields.
@mdumandag
add documentation to the writer and generic record api
74cff5d
@mdumandag mdumandag force-pushed the dont-allow-different-compact-array-types branch from fd41863 to 74cff5d Compare August 15, 2022 07:38
@hazelcast hazelcast deleted a comment from hz-devops-test Aug 15, 2022
@hazelcast hazelcast deleted a comment from hz-devops-test Aug 15, 2022
@hazelcast hazelcast deleted a comment from hz-devops-test Aug 15, 2022
@hazelcast hazelcast deleted a comment from hz-devops-test Aug 15, 2022
@hazelcast hazelcast deleted a comment from hz-devops-test Aug 15, 2022
@hazelcast hazelcast deleted a comment from hz-devops-test Aug 15, 2022
@mdumandag mdumandag merged commit 5bcb6c0 into hazelcast:master Aug 15, 2022
@mdumandag mdumandag deleted the dont-allow-different-compact-array-types branch August 15, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihsandemir ihsandemir ihsandemir approved these changes

@srknzl srknzl srknzl approved these changes

Assignees

@mdumandag mdumandag

Labels
Add to Release Notes All Languages Should Check Used by clients team to track fixes on the java client that should potentially backported to others Module: Serialization Source: Internal PR or issue was opened by an employee Team: Client
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mdumandag @hz-devops-test @ihsandemir @srknzl