Improve IO pipelines [5.0.5] [HZ-1884] #24893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [HZ-940] Improve IO pipelines (hazelcast#21066) * Wait for the decoder's protocol confirmation before sending the member data [HZ-1163] (hazelcast#21391) * Add null checks to SingleProtocolEncoder protocol verification signals (hazelcast#21497) Co-authored-by: ufukyilmaz <ufuk.yilmaz@hazelcast.com>
kwart
added
Type: Defect
Team: Core
Backport
Source: Internal
|
The job Click to expand the log file---------ERRORS----------- -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-builder_2/hazelcast/src/test/java/com/hazelcast/internal/server/tcp/ProtocolNegotiationTest.java:2: Line does not match expected header line of ' * Copyright (c) 2008-2021, Hazelcast, Inc. All Rights Reserved.'. [Header] -------------------------- |
olukas
approved these changes
Jun 23, 2023
|
The job Click to expand the log file-------------------------- ---------SUMMARY---------- -------------------------- [ERROR] COMPILATION ERROR : -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/nio/ssl/MemberTLSChannelInitializer.java:[31,48] error: no suitable constructor found for SingleProtocolDecoder(ProtocolType,InboundHandler[],SingleProtocolEncoder,boolean) -------------------------- ---------ERRORS----------- -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/nio/ssl/MemberTLSChannelInitializer.java:[31,48] error: no suitable constructor found for SingleProtocolDecoder(ProtocolType,InboundHandler[],SingleProtocolEncoder,boolean) -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/nio/ssl/MemberTLSChannelInitializer.java:[31,48] error: no suitable constructor found for SingleProtocolDecoder(ProtocolType,InboundHandler[],SingleProtocolEncoder,boolean) -------------------------- |
|
The job Click to expand the log file-------------------------- ---------SUMMARY---------- -------------------------- [ERROR] COMPILATION ERROR : -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler_2/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/nio/ssl/MemberTLSChannelInitializer.java:[31,48] error: no suitable constructor found for SingleProtocolDecoder(ProtocolType,InboundHandler[],SingleProtocolEncoder,boolean) -------------------------- ---------ERRORS----------- -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler_2/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/nio/ssl/MemberTLSChannelInitializer.java:[31,48] error: no suitable constructor found for SingleProtocolDecoder(ProtocolType,InboundHandler[],SingleProtocolEncoder,boolean) -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler_2/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/nio/ssl/MemberTLSChannelInitializer.java:[31,48] error: no suitable constructor found for SingleProtocolDecoder(ProtocolType,InboundHandler[],SingleProtocolEncoder,boolean) -------------------------- |
|
The job Click to expand the log file-------------------------- -------TEST FAILURE------- -------------------------- [INFO] Results: [INFO] [ERROR] Failures: [ERROR] SqlErrorTest.testUserCancel:109->SqlErrorAbstractTest.checkUserCancel:141 Exception is not thrown [INFO] [ERROR] Tests run: 4133, Failures: 1, Errors: 0, Skipped: 59 [INFO] |
It was a test issue. The SqlResult is automatically closed when the backing job completes (for member cursors) or when all rows are fetched (for client cursor). A sleep inserted before `res.close()` reproduced the issue (only for member, because for client the fetch size was set to 1 and the client would never fetch all rows at that point. Fixed by replacing the query with a streaming one. Fixes hazelcast#20336
|
The job Click to expand the log file-------------------------- ---------SUMMARY---------- -------------------------- [ERROR] COMPILATION ERROR : -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/nio/ssl/MemberTLSChannelInitializer.java:[31,48] error: no suitable constructor found for SingleProtocolDecoder(ProtocolType,InboundHandler[],SingleProtocolEncoder,boolean) -------------------------- ---------ERRORS----------- -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/nio/ssl/MemberTLSChannelInitializer.java:[31,48] error: no suitable constructor found for SingleProtocolDecoder(ProtocolType,InboundHandler[],SingleProtocolEncoder,boolean) -------------------------- [ERROR] /home/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/nio/ssl/MemberTLSChannelInitializer.java:[31,48] error: no suitable constructor found for SingleProtocolDecoder(ProtocolType,InboundHandler[],SingleProtocolEncoder,boolean) -------------------------- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports (cherry-picks) #21066 #21391 #21497 to
5.0.5.EE part of the fix for hazelcast/hazelcast-enterprise#6181