Client ssl engine doesn't need keyStore and keyStorePassword #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdogan
added a commit
that referenced
this pull request
May 22, 2014
Client ssl engine doesn't need keyStore and keyStorePassword
devOpsHazelcast
pushed a commit
that referenced
this pull request
Jul 11, 2024
] (#2525) [Confluent 7.6 only supports Kafka 3.6.x](https://docs.confluent.io/platform/current/installation/versions-interoperability.html#cp-and-apache-ak-compatibility), but in hazelcast/hazelcast-mono#2498 ~we~ I upgraded to `3.7.1`. [Kafka 3.7 introduced a breaking change](apache/kafka#14111), which [caused test failures](#26372). As part of hazelcast/hazelcast-mono#2498, I also unified the version of `kafka-clients` to use the same property (rather than just incrementing the version to `3.7.1`) to ensure consistency going forwards. I **have not reverted** this change, which means this PR will effectively downgrade `kafka-clients` from `3.7.0` (the version _before_ the upgrade in hazelcast/hazelcast-mono#2498) to `3.6.1`. The reason for this is that if Confluent 7.6 doesn't support Kafka 3.7, there may be other issues like this our test suite hasn't exposed. Fixes: #26372 [[HZ-4815]] [HZ-4815]: https://hazelcast.atlassian.net/browse/HZ-4815?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Burak Gök <burak.gok@hazelcast.com> GitOrigin-RevId: ed25d207d11922a98ff4f9f00a0f2c609d330c3a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.