Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SQL connector preferredLocalParallelism option #26194

Closed
wants to merge 2 commits into from
Closed

Implement SQL connector preferredLocalParallelism option #26194

wants to merge 2 commits into from

Conversation

hhromic
Copy link
Contributor

@hhromic hhromic commented Dec 21, 2023

This PR implements a new SQL mapping option to define the preferred local parallelism for connectors that support configuring it. At the moment, only the Kafka connector supports this. See linked issue for more details.

Fixes #24357

No Breaking changes.

Checklist:

  • Labels (Team:, Type:, Source:, Module:) and Milestone set
  • Add Add to Release Notes label if changes should be mentioned in release notes or Not Release Notes content if changes are not relevant for release notes
  • Request reviewers if possible
  • New public APIs have @Nonnull/@Nullable annotations
  • New public APIs have @since tags in Javadoc
  • Send backports/forwardports if fix needs to be applied to past/future releases

@hz-devops-test hz-devops-test added the Source: Community PR or issue was opened by a community user label Dec 21, 2023
@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

3 similar comments
@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

Internal PR hazelcast/hazelcast-mono#254
Internal message only. Nothing to see here, move along

@hhromic
Copy link
Contributor Author

hhromic commented Jan 18, 2024

Anything I can do on my side to help moving this PR forward? Thanks!

@hhromic
Copy link
Contributor Author

hhromic commented Jan 28, 2024

Rebased on top of current master.

@k-jamroz
Copy link
Collaborator

@hhromic Thank you for your contribution!

@k-jamroz k-jamroz closed this Jan 29, 2024
devOpsHazelcast pushed a commit that referenced this pull request Jan 29, 2024
This PR implements a new SQL mapping option to define the preferred
local parallelism for connectors that support configuring it. At the
moment, only the Kafka connector supports this. See linked issue for
more details.

Fixes #24357
Closes #26194

Co-authored-by: Hugo Hromic <hhromic@gmail.com>
GitOrigin-RevId: d80406e5a54db45a2bedc435c1956d221cc42d6a
@hhromic hhromic deleted the sql-plp-option branch January 29, 2024 14:32
Serdaro pushed a commit to hazelcast/hz-docs that referenced this pull request Feb 4, 2024
* Document `preferredLocalParallelism` SQL Kafka mapping option

* Implemented in <hazelcast/hazelcast#26194>

* Update docs/modules/sql/pages/mapping-to-kafka.adoc

Co-authored-by: rebekah-lawrence <142301480+rebekah-lawrence@users.noreply.github.com>

* Update docs/modules/sql/pages/mapping-to-kafka.adoc

Co-authored-by: rebekah-lawrence <142301480+rebekah-lawrence@users.noreply.github.com>

* Update docs/modules/sql/pages/mapping-to-kafka.adoc

Co-authored-by: rebekah-lawrence <142301480+rebekah-lawrence@users.noreply.github.com>

* Update docs/modules/sql/pages/mapping-to-kafka.adoc

Co-authored-by: rebekah-lawrence <142301480+rebekah-lawrence@users.noreply.github.com>

* Update docs/modules/sql/pages/mapping-to-kafka.adoc

Co-authored-by: rebekah-lawrence <142301480+rebekah-lawrence@users.noreply.github.com>

* Update docs/modules/sql/pages/mapping-to-kafka.adoc

Co-authored-by: rebekah-lawrence <142301480+rebekah-lawrence@users.noreply.github.com>

* More precise wording and move info about default above

---------

Co-authored-by: rebekah-lawrence <142301480+rebekah-lawrence@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL Connector option to set preferred local parallelism
5 participants