Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document preferredLocalParallelism SQL Kafka mapping option #985

Merged
merged 8 commits into from
Feb 4, 2024
Merged

Document preferredLocalParallelism SQL Kafka mapping option #985

merged 8 commits into from
Feb 4, 2024

Conversation

hhromic
Copy link
Contributor

@hhromic hhromic commented Feb 1, 2024

This PR documents the new preferredLocalParallelism SQL Kafka mapping option from hazelcast/hazelcast#26194.
I also took the opportunity to align the formatting of other existing options in the example.

Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for hardcore-allen-f5257d ready!

Name Link
🔨 Latest commit fe28b0d
🔍 Latest deploy log https://app.netlify.com/sites/hardcore-allen-f5257d/deploys/65bc31c687c59c000813bf94
😎 Deploy Preview https://deploy-preview-985--hardcore-allen-f5257d.netlify.app/hazelcast/5.4-snapshot/sql/mapping-to-kafka
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@rebekah-lawrence rebekah-lawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the submission, I have made a few suggestions for your consideration.

docs/modules/sql/pages/mapping-to-kafka.adoc Outdated Show resolved Hide resolved
docs/modules/sql/pages/mapping-to-kafka.adoc Outdated Show resolved Hide resolved
docs/modules/sql/pages/mapping-to-kafka.adoc Outdated Show resolved Hide resolved
docs/modules/sql/pages/mapping-to-kafka.adoc Outdated Show resolved Hide resolved
docs/modules/sql/pages/mapping-to-kafka.adoc Outdated Show resolved Hide resolved
docs/modules/sql/pages/mapping-to-kafka.adoc Outdated Show resolved Hide resolved
hhromic and others added 7 commits February 1, 2024 22:27
Co-authored-by: rebekah-lawrence <142301480+rebekah-lawrence@users.noreply.github.com>
Co-authored-by: rebekah-lawrence <142301480+rebekah-lawrence@users.noreply.github.com>
Co-authored-by: rebekah-lawrence <142301480+rebekah-lawrence@users.noreply.github.com>
Co-authored-by: rebekah-lawrence <142301480+rebekah-lawrence@users.noreply.github.com>
Co-authored-by: rebekah-lawrence <142301480+rebekah-lawrence@users.noreply.github.com>
Co-authored-by: rebekah-lawrence <142301480+rebekah-lawrence@users.noreply.github.com>
@hhromic
Copy link
Contributor Author

hhromic commented Feb 2, 2024

@rebekah-lawrence thanks again for your feedback and review.
I now made another round of rewording and editing. Please let me know if this is better now!

Copy link
Contributor

@rebekah-lawrence rebekah-lawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution, and all the work you have put into it. It looks good to me.

I hope you enjoyed it, and we see you back again!

Copy link
Contributor

@Serdaro Serdaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for the contribution @hhromic

@Serdaro Serdaro merged commit 154706d into hazelcast:main Feb 4, 2024
6 checks passed
@hhromic hhromic deleted the document-sql-plp-option branch February 4, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants