-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document preferredLocalParallelism
SQL Kafka mapping option
#985
Conversation
✅ Deploy Preview for hardcore-allen-f5257d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the submission, I have made a few suggestions for your consideration.
Co-authored-by: rebekah-lawrence <142301480+rebekah-lawrence@users.noreply.github.com>
Co-authored-by: rebekah-lawrence <142301480+rebekah-lawrence@users.noreply.github.com>
Co-authored-by: rebekah-lawrence <142301480+rebekah-lawrence@users.noreply.github.com>
Co-authored-by: rebekah-lawrence <142301480+rebekah-lawrence@users.noreply.github.com>
Co-authored-by: rebekah-lawrence <142301480+rebekah-lawrence@users.noreply.github.com>
Co-authored-by: rebekah-lawrence <142301480+rebekah-lawrence@users.noreply.github.com>
@rebekah-lawrence thanks again for your feedback and review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution, and all the work you have put into it. It looks good to me.
I hope you enjoyed it, and we see you back again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks a lot for the contribution @hhromic
This PR documents the new
preferredLocalParallelism
SQL Kafka mapping option from hazelcast/hazelcast#26194.I also took the opportunity to align the formatting of other existing options in the example.