Lock resource cleanup on member left #5601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2015
pveentjer
changed the title
| for (LockStoreImpl lockStore : container.getLockStores()) { | ||
| releaseLock(uuid, container, lockStore); | ||
| } | ||
| private void releaseLocksOf(final String uuid) { |
There was a problem hiding this comment.
perhaps releaseLocksFrom? or releaseLockedOwnedBy?
There was a problem hiding this comment.
ok, renaming to releaseLocksOwnedBy.
|
I don't see any tests added. We need to have some in place to verify if the behavior works correctly. |
|
If you can add some tests, I'm fine with merging it. |
Problem is, this is to fix a race between cleanup operation and lock operation. I'll try to write a stress test to create the issue but I'm not sure if I ever will be able to. |
|
Finally I'm able to reproduce the race with a custom lock operation: 16b6d86 |
…d on related partition threads, otherwise it can miss previously enqueued or being executed lock operations. So, this race can cause infinitely hanging locks. - Lock cleanup operation should check owner-uuid during its execution in partition thread to avoid race.
|
verify |
1 similar comment
|
verify |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #5246