Fix Invalidconfigtest #8422
Closed
Fix Invalidconfigtest #8422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One should not assert on generated strings.
| @@ -298,7 +298,7 @@ public void async_whenEventuallyHeartbeatTimeout_thenOperationTimeoutException() | |||
|
|
|||
| @Test | |||
| public void sync_whenCallTimeout_thenOperationTimeoutException() throws Exception { | |||
| long callTimeoutMs = 10000; | |||
| long callTimeoutMs = 60000; | |||
There was a problem hiding this comment.
is this change intentionally in this PR?
|
Test PASSed. |
|
@pveentjer do you want to rebase it before code freeze? |
|
needs rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8169
Bad practice to assert on generated strings by a implementation not controlled by us.