Access ICache's via separate ICacheManager available from HazelcastInstance #8434
Conversation
|
Test PASSed. |
1 similar comment
|
Test PASSed. |
| * Hazelcast's {@link javax.cache.spi.CachingProvider#getDefaultClassLoader()}) | ||
| * @return the name of the {@link ICache} distributed object corresponding to given arguments. | ||
| */ | ||
| public static String getDistributedObjectName(String cacheName, URI uri, ClassLoader classLoader) { |
There was a problem hiding this comment.
minor comment: Since generally URI and ClassLoader parameters are null, it might be good if we support also String getDistributedObjectName(String cacheName) version of this method.
|
👍 minor comment |
| * | ||
| * @see ICacheManager | ||
| */ | ||
| public class HazelcastClientInstanceCacheManager implements ICacheManager { |
There was a problem hiding this comment.
Do we need the Hazelcast prefix? Why not call it ClientICacheManager?
…returned by HazelcastInstance.getCacheManager()
vbekiaris
force-pushed
the
fixes/master/get-cache-indirectly
branch
from
8120a2b
to
bfd2037
Compare
|
Thanks @serkan-ozal & @pveentjer for the quick review. Your comments have been addressed; with regards to class naming, since there are already a few |
|
👍 once green |
|
Test PASSed. |
Access to
ICacheinstances is now available via separateICacheManagerinterface which is accessible fromHazelcastInstance.getCacheManager.Fixes #8352 .
An EE counterpart is required.
Also provides a new utility method
CacheUtil.getDistributedObjectName(in a separate commit).