fixed multicast plugin bug and added test #8614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
| @@ -47,7 +48,9 @@ public void setUp() { | |||
|
|
|||
| System.setProperty(TestEnvironment.HAZELCAST_TEST_USE_NETWORK, "true"); | |||
| System.setProperty("java.net.preferIPv4Stack", "true"); | |||
| factory = createHazelcastInstanceFactory(2); | |||
| if (factory == null) { | |||
There was a problem hiding this comment.
Do we really need this? factory is already defined in HazelcastTestSupport so all cleanup, null checking etc. looks unnecessary to me.
I believe we should remove factory variable in this class and depend on the one @ HazelcastTestSupport. Good cleanup opportunity for you 👍
|
👍 with minor comment. Can you please add bug description as well? invalid port fix etc. |
bilalyasar
force-pushed
the
bilalyasar-mp-fix
branch
from
abc2fb3
to
1b2045b
Compare
|
@mesutcelik reviewed your comments, also added description. |
|
Test PASSed. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have rebased and opened new pr from this pr:
#8421