Allow member without JCache in classpath to join cluster when no Cache configurations are defined #9459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
…when no Cache configurations are defined
vbekiaris
force-pushed
the
fixes/3.8/jcache-join
branch
from
c1cddcc
to
5709318
Compare
|
Test PASSed. |
ahmetmircik
reviewed
Dec 19, 2016
| ICacheService cacheService = getService(); | ||
| for (CacheConfig cacheConfig : configs) { | ||
| cacheService.putCacheConfigIfAbsent(cacheConfig); | ||
| if (isJcacheAvailable(getNodeEngine().getConfigClassLoader())) { |
There was a problem hiding this comment.
isJCacheAvailable with capital C (it is not introduced here but just wanted to note)
There was a problem hiding this comment.
Thanks @ahmetmircik , I renamed the methods in JCacheDetector with a capital C in a separate commit. Once green will squash & merge.
|
Test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows a member without JCache API in its classpath to join a cluster whose members do have the JCache API, when JCache is not used (no
CacheConfigs are already defined) and log a warning that if JCache API will be used, it will fail.Also prints an informative
SEVEREmessage in caseCacheConfigs are delivered in thePostJoinCacheOperationbut JCache API artifact is missing from the classpath (currently, a service not found exception is logged that indicates thatCacheServiceis not available but does not provide information towards resolving the issue).Fixes #9301