Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redesign the core composition hirearchy #39

Merged
merged 1 commit into from
Mar 19, 2018

Conversation

hbagdi
Copy link
Owner

@hbagdi hbagdi commented Mar 19, 2018

  • introduce recursive composition of Unsplash type
    which holds the client
  • remove the ugly type casting code from the entire library

- introduce recursive composition of Unsplash type
which holds the client
- remove the ugly type casting code from the entire library
@codecov
Copy link

codecov bot commented Mar 19, 2018

Codecov Report

Merging #39 into master will decrease coverage by 0.46%.
The diff coverage is 97.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   79.84%   79.38%   -0.47%     
==========================================
  Files          17       17              
  Lines         893      873      -20     
==========================================
- Hits          713      693      -20     
  Misses        136      136              
  Partials       44       44
Impacted Files Coverage Δ
unsplash/users_service.go 85.07% <100%> (-0.64%) ⬇️
unsplash/photos_service.go 85.13% <100%> (-0.68%) ⬇️
unsplash/collections_service.go 87.27% <100%> (-0.66%) ⬇️
unsplash/get_helpers.go 87.5% <100%> (ø) ⬆️
unsplash/search_service.go 89.28% <100%> (-0.55%) ⬇️
unsplash/unsplash.go 72.22% <92.85%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba30b70...652c6a3. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 81.843% when pulling 652c6a3 on fix/service-compostion into ba30b70 on master.

@hbagdi hbagdi merged commit ff222b5 into master Mar 19, 2018
@hbagdi hbagdi deleted the fix/service-compostion branch March 19, 2018 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants