Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure audio callback #145

Merged
merged 4 commits into from Aug 31, 2021
Merged

Restructure audio callback #145

merged 4 commits into from Aug 31, 2021

Conversation

hbeni
Copy link
Owner

@hbeni hbeni commented Aug 30, 2021

Plugin: refactored audio filters to be model specific

The previously global audio filters are now part of the radio model.
Now we can define different audio filter characteristics for different radio models.
This also made the mumble_onAudioSourceFetched a little less long and a little more generic.

@hbeni
Plugin: replace calls to "<vector>.size() == 0" with "<vector>.empty()"
f4b8a6c 
(partly implements ref #58)
@hbeni
Plugin: Remove unneccesary calls to empty() before indexed loops
a5d58f0 
The head-controlled loops already checks against size(), so does not run for empty() vectors anyway!
@hbeni
Plugin/Geotest: Fix compiler warning (unused for increment)
2d9f25b 
The increment is done manually in the loop body
@hbeni hbeni linked an issue Aug 30, 2021 that may be closed by this pull request
Make minimum noise/audio filters depending on radio model #122
Closed
@hbeni
Copy link
Owner Author

hbeni commented Aug 30, 2021 •
edited

Rough local checks yielded good results.

Checked (radioGUI/two local mumble instances on local murmurd):

  • frequency match with STRING and VHF models (and UHF and HF are based on that)
  • played with different signal strengths/distances
  • played around with different frequencies and radio combinations
  • played around with the "can hear non-plugin-users" feature
  • played around with the squelch
  • played around with the volume
  • played around with the power button (internal operable flag)
  • verified half-duplex muting when sending over active transmission

Looks all good to me.

@hbeni
Plugin: refactored audio filters to be model specific
3abc7bb 
The previously global audio filters are now part of the radio model.
Now we can define different audio filter characteristics for different radio models.
This also made the mumble_onAudioSourceFetched a little less long and a little more generic.

Fix #122
Helps with #58
@hbeni hbeni merged commit e1c1fc3 into master Aug 31, 2021
@hbeni hbeni deleted the restructureAudioCallback branch August 31, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make minimum noise/audio filters depending on radio model
1 participant
@hbeni