Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure audio callback #145

Merged
merged 4 commits into from Aug 31, 2021
Merged

Restructure audio callback #145

merged 4 commits into from Aug 31, 2021

Commits on Aug 30, 2021

  1. Plugin: replace calls to "<vector>.size() == 0" with "<vector>.empty()" 

    (partly implements ref #58)
    @hbeni
    hbeni committed Aug 30, 2021
    Copy the full SHA
    f4b8a6c View commit details
    Browse the repository at this point in the history

  2. Plugin: Remove unneccesary calls to empty() before indexed loops 

    The head-controlled loops already checks against size(), so does not run for empty() vectors anyway!
    @hbeni
    hbeni committed Aug 30, 2021
    Copy the full SHA
    a5d58f0 View commit details
    Browse the repository at this point in the history

  3. Plugin/Geotest: Fix compiler warning (unused for increment) 

    The increment is done manually in the loop body
    @hbeni
    hbeni committed Aug 30, 2021
    Copy the full SHA
    2d9f25b View commit details
    Browse the repository at this point in the history

  4. Plugin: refactored audio filters to be model specific 

    The previously global audio filters are now part of the radio model.
Now we can define different audio filter characteristics for different radio models.
This also made the mumble_onAudioSourceFetched a little less long and a little more generic.

Fix #122
Helps with #58
    @hbeni
    hbeni committed Aug 30, 2021
    Copy the full SHA
    3abc7bb View commit details
    Browse the repository at this point in the history