-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mypy for type checking #67
Conversation
e474998
to
976bc87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good thing to do. I would never have done it myself, but I see the value.
Could you please add a contributing.rst
in the docs or something similar and provide me (and potential other contributors) information about how to conform to this?
Absolutely, good idea! |
4377738
to
232fceb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing! Great work. I will merge this now and release it soon.
There are some type annotations already but there are some errors here and there. Since I think type annotations are very nice and helps a lot in both developing and using a library, I think the time has come to also use mypy for type checking.
The final goal here is to also type the json/dicts returned from the BankID API using
typing.TypedDict
but that's another story.I intentionally didn't add type annotations to bankid/experimental since it's...experimental anyway 馃樃