Mypy-enabled PyBankID #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected typo in examples
Fix breakage with urllib 2.0.x
Update __init__.py
The BankID pages now returns a captcha instead of the actual certificate when fetching with requests. The actual cert is now bundled instead of fetched each time.
Bundle pem formats as well.
Fixes for test certificate download and handling
* Test against Python 3.12 * Install setuptools after testing * Swap out pkg_resources for importlib * Downgrade importlib-resources to 5.12.0 * Always use compat package * Read required packages in setup.py from requirements.txt * Drop unused six and update docs * Async client * Tidy up async wrapper * Install requirements-dev.txt on CI * Add two more packages to requirements-dev.txt from CI * Update bankid/jsonclient.py Co-authored-by: David Svenson <davidsvenson@outlook.com> * Update bankid/jsonclient.py Co-authored-by: David Svenson <davidsvenson@outlook.com> * Drop unused TypeVar * Update bankid/jsonclient.py Co-authored-by: David Svenson <davidsvenson@outlook.com> --------- Co-authored-by: David Svenson <davidsvenson@outlook.com>
Add support for RP v6.0
Documentation fixes Renaming and docstring fixes Demo app modifications Version bump
Removed testing in windows and macos Also removed 3.7 and 3.8 from test matrix.
Make it even easier to retrieve the test certificate by writing it into the current directory if no path is supplied.
This simplifies making use of it without having access to a client instance.
pytest is the "new" name :)
Expose QR code helper explicitly
Update README.rst - use pytest instead of py.test
Also, only keep a sync version of the ip_address fixture. This avoids httpbin flakyness/unrelibility since the ip address fetch only needs to happen once.
Supporting Python >=3.9 does not require using the backport. Also, use joinpath() to simplify the retrival of the path+return pathlib.Path instead of str.
Cache ip addresses in test suite.
Use builtin importlib.resources.
Update certutils.py
Add mypy for type checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains changes made in #67, #66, #65, #63, #61.