Vectorized contour reconstruction function #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbldh
added a commit
that referenced
this pull request
Jul 27, 2019
Merge #4 Updated docstring for new method. Ran Black on code. Removed scipy dep from requiremn
|
Sorry for leaving this hanging. I accidentally forgot it even though I found it to be a very good addition. One thing I noticed while merging; there is no documentation for this new feature. I wrote a docstring (please check it if it is good enough), but if you have a real example of how to use your new method, would you mind adding it to the |
|
Sure, just got back from my holiday and picking up work again so it may take a few days, but I agree this is a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope to contribute some more to this project with an extracted contour reconstruction function. Refactored tests accordingly. To compare reconstructed shapes I had to import a reliable hausdorff distance function, for which the scipy package was included in the test requirements.