Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete properties #8

Closed
dr0i opened this issue Dec 17, 2015 · 10 comments
Closed

Remove obsolete properties #8

dr0i opened this issue Dec 17, 2015 · 10 comments
Assignees
Labels

Comments

@dr0i
Copy link
Member

dr0i commented Dec 17, 2015

We have a workaround lv:nameOfContributingCorporateBody (introduced with hbz/lobid#38), where we subsume literals of corporate bodies, be they creators or contributors. I think this property will be made obsolet by the new lv:contributorOrder , right?

@acka47 acka47 added the launch label Mar 11, 2016
@acka47 acka47 changed the title What to do with lv:nameOfContributingCorporateBody ? Remove obsolete properties Mar 11, 2016
@acka47
Copy link
Contributor

acka47 commented Mar 11, 2016

I re-neamed this ticket to a more general task: remove obsolete properties after properly implementing API 2.0.

When we are properly done with API 2.0 the following properties should be obsolete and should be removed before going into production:

@acka47 acka47 assigned dr0i and unassigned acka47 Mar 11, 2016
@acka47
Copy link
Contributor

acka47 commented Apr 26, 2016

The question is whether these properties are really obsolete or whether they still contain information that isn't found elsewhere. For example, I just noticed that subjectlabel contains information from fields 710/711 that is not – and should not – be moved to the subject array. Example TT002234459 (snippet):

<datafield tag="710" ind1="-" ind2="1">
  <subfield code="a">
Wandern, Diez, Lahnstein, Rhein-Lahn-Info, Rhein, Lahn, Wirtschaftsförderung
  </subfield>
</datafield>

We might not want to have it in the subject array as it would be mistaken as some part of an RSWK subject chain. (There is still the possibility, though, that we need a field like subjectChain or subjectOrder for providing required functionality like "Themensuche" in NWBib).

We will have to take this into account before removing properties. One possibility for 710/711 might be to switch back to dc:subject for this when we don't list the strings together with alternate names of GND subjects...

@acka47
Copy link
Contributor

acka47 commented Sep 15, 2016

Talking to @jschnasse the other day, it became clear that we should keep "subjectOrder" as we can not group multiple subject chains in a subject array.

@dr0i dr0i added the ready label Dec 21, 2016
@dr0i dr0i assigned acka47 and unassigned dr0i Dec 21, 2016
@dr0i
Copy link
Member Author

dr0i commented Dec 21, 2016

Look at the status quo of API 2.0 I think we may close this ticket. Only subjectChain is still used and will be in the future because at the moment json-ld doesn't support lists in lists, yes @acka47 ?

@acka47
Copy link
Contributor

acka47 commented Dec 21, 2016

In #8 (comment), I ticked the properties that already have been removed. Is this correct? This means, we will keep subjectLabel, subjectOrder and subjectChain for now. I would be ok with this.

@fsteeg fsteeg changed the title Remove obsolete properties Remove obsolete properties Jan 3, 2017
@acka47
Copy link
Contributor

acka47 commented Jan 18, 2017

I found another property that should be removed: volume. Since lobid/lodmill#497 we don't need it anymore and only retained it because edoweb still needed it, see lobid/lodmill#497 (comment) ff.

@acka47 acka47 assigned dr0i and acka47 and unassigned acka47 and dr0i Jan 18, 2017
acka47 added a commit that referenced this issue Jan 18, 2017
@acka47 acka47 added working and removed ready labels Jan 18, 2017
@acka47 acka47 added ready and removed working labels Jan 18, 2017
@acka47 acka47 removed their assignment Jan 18, 2017
@acka47
Copy link
Contributor

acka47 commented Feb 14, 2017

Reopening. These still have to be removed from the context/labels.json:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants