-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource queries based on alternate labels of creators and contributors #38
Comments
No, we of course shouldn't use
❗ We will have to add |
For now, we need a seperate property with preferred and alternative names to be queried by elasticsearch, see also – the redundant – issue #85. We will follow the approach outlined above in lobid API 2.0, though. |
Which property to use? I think the way to go is by using |
We should use two different properties for contributors that are persons and contributors that are organization. Then we can easily provide a search for corporate bodies, see hbz/nwbib#54. Which property to use for corporate bodies? I suggest two options:
What do you think @dr0i? |
If I understand correctly, we won't build the graph structure you mentionend in #38 (comment) . That woul be good because we can't build that structure directly by transforming the catalog - that would be possible only with API 2.0. |
…xists See hbz/lobid#38. * update test
…xists See hbz/lobid#38. * update tests
@dr0i I have nothing to add or correct regarding your previous comment. Looking forward to the test data. |
See hbz/lobid#38. * add tests
Deployed to staging. |
+1 |
We have to find out what the reason is for this discrepancy in the results:
This discrepancy seems ok as there probably are a lot of titles with "Johann Wolfgang von Goethe" in field
This doesn't seem right. What is the reason for this behaviour? I couldn't find out yet. |
Apart from the problem pointed out in the last comment, this looks good. |
Please deploy on production. We'll sort eventual other issues out seperately. |
Deployed to production, closing. |
Goal:
The text was updated successfully, but these errors were encountered: