Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource queries based on alternate labels of creators and contributors #38

Closed
acka47 opened this issue Aug 22, 2014 · 20 comments
Closed
Assignees

Comments

@acka47
Copy link
Contributor

acka47 commented Aug 22, 2014

@acka47 acka47 changed the title Enable resource query based on alternate labels of authors Resource query based on alternate labels of authors Aug 22, 2014
@acka47 acka47 changed the title Resource query based on alternate labels of authors Resource queries based on alternate labels of authors Aug 22, 2014
@acka47 acka47 added the ready label Aug 22, 2014
@dr0i
Copy link
Member

dr0i commented Aug 22, 2014

This means to take all expanded names into the index. As @acka47 @fsteeg and me discussed we should taek the data from the aleph mab xml. Associate litrals with dc:subject.

@acka47
Copy link
Contributor Author

acka47 commented Oct 13, 2014

No, we of course shouldn't use dc:subject here. (Though we may use it in #39.) I'd suggest we rather keep the structure we have today,e.g.:

{
  "@graph" : [ {
    "preferredName" : "Goethe, Johann Wolfgang von",
    "preferredNameForThePerson" : "Goethe, Johann Wolfgang von"
    "variantName":  [ "Gėtė, Johanas Volfgangas ", "Gete, Volʹfgang",  "ゲーテ, ヨハン・ヴォルフガング・フォン ",  ...]
    }, {
    "@id" : "http://lobid.org/resource/HT008727850",
    "@type" : [ "http://purl.org/vocab/frbr/core#Manifestation", "http://purl.org/ontology/bibo/Book", "http://purl.org/dc/terms/BibliographicResource" ],
    "publisher" : "Saur",
    "creator" : "http://d-nb.info/gnd/118540238",
    "issued" : "1788",
    "title" : "Egmont",
     ...
  } ],
  "@context" : "http://api.lobid.org/context/lobid-resources.json",
  "@id" : "http://lobid.org/resource/HT008727850/about",
  "primaryTopic" : "http://lobid.org/resource/HT008727850"
}

❗ We will have to add gnd:variantName (http://d-nb.info/standards/elementset/gnd#variantName) to the JSON-LD context.

@acka47 acka47 changed the title Resource queries based on alternate labels of authors Resource queries based on alternate labels of creators and contributors Jan 14, 2015
@acka47
Copy link
Contributor Author

acka47 commented Jan 14, 2015

For now, we need a seperate property with preferred and alternative names to be queried by elasticsearch, see also – the redundant – issue #85. We will follow the approach outlined above in lobid API 2.0, though.

@acka47 acka47 added working and removed ready labels Jan 14, 2015
@acka47 acka47 assigned acka47 and unassigned dr0i Jan 14, 2015
@acka47
Copy link
Contributor Author

acka47 commented Jan 14, 2015

Which property to use? I think the way to go is by using http://purl.org/dc/elements/1.1/contributor with a list of all name strings.

@acka47 acka47 assigned dr0i and unassigned acka47 Jan 14, 2015
@acka47 acka47 added ready and removed working labels Jan 14, 2015
@acka47
Copy link
Contributor Author

acka47 commented Jan 14, 2015

We should use two different properties for contributors that are persons and contributors that are organization. Then we can easily provide a search for corporate bodies, see hbz/nwbib#54.

Which property to use for corporate bodies? I suggest two options:

  • Using the lobid vocab namespace maybe without even adding the property in the vocab: lv:nameOfContributingCorporateBody
  • Or – to clearly show that this is a transitional property – http://example.org/nameOfContributingCorporateBody

What do you think @dr0i?

@dr0i
Copy link
Member

dr0i commented Feb 4, 2015

If I understand correctly, we won't build the graph structure you mentionend in #38 (comment) . That woul be good because we can't build that structure directly by transforming the catalog - that would be possible only with API 2.0.
For the properties directly clinging to the resource's subject:
fine with me. Would like to use lv:nameOfContributingCorporateBody since you control the vocabulary and may want to deprecate (or not) it later by your will.

@acka47
Copy link
Contributor Author

acka47 commented Feb 9, 2015

@dr0i I have nothing to add or correct regarding your previous comment. Looking forward to the test data.

@acka47 acka47 added the working label Feb 26, 2015
@acka47 acka47 assigned dr0i and unassigned acka47 Feb 26, 2015
dr0i added a commit to lobid/lodmill that referenced this issue Feb 26, 2015
@dr0i
Copy link
Member

dr0i commented Mar 3, 2015

Deployed to staging.
The resources mentioned in #38 (comment) now reveal the same result.

@dr0i dr0i assigned acka47 and unassigned dr0i Mar 3, 2015
@acka47
Copy link
Contributor Author

acka47 commented Mar 3, 2015

+1

@dr0i dr0i added deploy and removed review labels Mar 3, 2015
@dr0i dr0i assigned dr0i and unassigned acka47 Mar 3, 2015
@acka47 acka47 added review and removed deploy labels Mar 12, 2015
@acka47 acka47 assigned acka47 and unassigned dr0i Mar 12, 2015
@acka47
Copy link
Contributor Author

acka47 commented Mar 13, 2015

We have to find out what the reason is for this discrepancy in the results:

  • Querying for preferred label (curl "http://test.lobid.org/resource?author=Goethe,%20Johann%20Wolfgang%20von"): 21373 results
  • Querying for alternate label (curl "http://test.lobid.org/resource?author=Gede, Yuehan Wofugang"): 19949

This discrepancy seems ok as there probably are a lot of titles with "Johann Wolfgang von Goethe" in field statementOfResponsibility. But when we contrast this with a query for Goethe's GND ID, the discrepancy is way to big:

  • Querying for GND ID: curl "http://test.lobid.org/resource?author=118540238": 9826

This doesn't seem right. What is the reason for this behaviour? I couldn't find out yet.

@acka47
Copy link
Contributor Author

acka47 commented Mar 13, 2015

Apart from the problem pointed out in the last comment, this looks good.

@acka47
Copy link
Contributor Author

acka47 commented Mar 16, 2015

Please deploy on production. We'll sort eventual other issues out seperately.

@acka47 acka47 assigned dr0i and unassigned acka47 Mar 16, 2015
@acka47 acka47 added deploy and removed review labels Mar 16, 2015
@dr0i
Copy link
Member

dr0i commented Mar 16, 2015

Deployed to production, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants