Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSK-1370] Show selected filter values on top #3174

Merged
merged 9 commits into from May 16, 2023
Merged

[TSK-1370] Show selected filter values on top #3174

merged 9 commits into from May 16, 2023

Conversation

s0gorelkov
Copy link
Contributor

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

TSK-1370

@s0gorelkov
[TSK-1368] Instantly apply channel filter
dbb9537 
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
@s0gorelkov
[TSK-1370] Show selected filter values on top
9874a40 
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
@s0gorelkov
Merge branch 'main' into filter-values-sorting
50a792a
@s0gorelkov
[TSK-1370] Optimize filter values sorting
0e09dab 
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
@s0gorelkov
[TSK-1370] Add "debounce" util from "lodash"
d2ae62f 
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
@s0gorelkov
[TSK-1370] Debounce filter toggle
8a4f1a3 
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
@s0gorelkov
[TSK-1370] Replace lodash.debounce with timers
9725dae 
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
haiodo
haiodo reviewed May 15, 2023
View reviewed changes
plugins/view-resources/package.json Outdated
"fast-equals": "^2.0.3",
"@hcengineering/text-editor": "^0.6.0"
"lodash.debounce": "~4.0.8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need it?

@s0gorelkov
[TSK-1370] Remove extra dependencies
875e109 
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>
@s0gorelkov
Merge branch 'main' into filter-values-sorting
72feb7e 
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@icloud.com>

# Conflicts:
#	plugins/tracker-resources/src/components/sprints/SprintFilter.svelte
@haiodo haiodo merged commit a711278 into main May 16, 2023
7 checks passed
@haiodo haiodo deleted the filter-values-sorting branch May 16, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

@BykhovDenis BykhovDenis Awaiting requested review from BykhovDenis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@s0gorelkov @haiodo