Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-135/TSK-1430: allow changing image in PDFViewer through arrow-keys (keyboard) #3186

Merged
merged 7 commits into from May 24, 2023
Merged

UBER-135/TSK-1430: allow changing image in PDFViewer through arrow-keys (keyboard) #3186

merged 7 commits into from May 24, 2023

Conversation

ThetaDR
Copy link
Member

@ThetaDR ThetaDR commented May 15, 2023

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

https://front.hc.engineering/workbench/platform/tracker/TSK-1430

A list of closed updated issues

haiodo
haiodo reviewed May 15, 2023
View reviewed changes
packages/ui/src/popups.ts Outdated Show resolved Hide resolved
@ThetaDR ThetaDR force-pushed the TSK-1430 branch 2 times, most recently from c40f9f8 to b004ad3 Compare May 17, 2023 06:30
@ThetaDR ThetaDR changed the title TSK-1430: allow changing image in PDFViewer through arrow-keys (keyboard) UBER-135/TSK-1430: allow changing image in PDFViewer through arrow-keys (keyboard) May 17, 2023
@ThetaDR ThetaDR requested a review from haiodo May 19, 2023 12:03
@ThetaDR
TSK-1430: Move ActionContext to presentation
4d2354e 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
TSK-1430: Add function for updating popup
d869b7f 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
TSK-1430: Allow changing image in popup viewer through arrows on a ke…
8661878 
…yboard

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
TSK-1430: code review fixes
f5551b6 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
TSK-1430: code review fixes-2
58fa88e 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
TSK-1430: fix svelte-check & rebase
466bd29 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
UBER-135: rebase and fix import
4f24ec4 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@BykhovDenis BykhovDenis merged commit df5fc73 into main May 24, 2023
7 checks passed
@BykhovDenis BykhovDenis deleted the TSK-1430 branch May 24, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

@BykhovDenis BykhovDenis Awaiting requested review from BykhovDenis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ThetaDR @haiodo @BykhovDenis