Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UBER-55] Remember collapsed projects #3194

Merged
merged 2 commits into from May 16, 2023
Merged

[UBER-55] Remember collapsed projects #3194

merged 2 commits into from May 16, 2023

Conversation

wazsone
Copy link
Contributor

@wazsone wazsone commented May 16, 2023

Contribution checklist

Related issues

https://front.hc.engineering/workbench/platform/tracker/UBER-55

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

@wazsone
remember collapsed projects
6fc10ec 
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
@wazsone wazsone self-assigned this May 16, 2023
BykhovDenis
BykhovDenis reviewed May 16, 2023
View reviewed changes
Copy link
Member

@BykhovDenis BykhovDenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haiodo should we have the same for categories in chunter/leads?

plugins/tracker-resources/src/components/projects/ProjectSpacePresenter.svelte Outdated
@@ -27,16 +27,23 @@
export let currentSpecial: string | undefined
export let getActions: Function
export let deselect: boolean = false

const COLLAPSED = 'COLLAPSED'
const getSpaceCollapsedKey = () => `${space._id}_collapsed`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use workspace id too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you.
Done.

@wazsone
use workspace id
726fd26 
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
@wazsone wazsone requested a review from BykhovDenis May 16, 2023 10:53
@haiodo haiodo merged commit 3d37ac6 into main May 16, 2023
7 checks passed
@haiodo haiodo deleted the UBER-55/collapsed-projects branch May 16, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

@BykhovDenis BykhovDenis BykhovDenis approved these changes

Assignees

@wazsone wazsone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wazsone @haiodo @BykhovDenis