Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UBER-118] Forbid unwanted symbols in a workspace name #3197

Merged
merged 2 commits into from May 17, 2023
Merged

[UBER-118] Forbid unwanted symbols in a workspace name #3197

merged 2 commits into from May 17, 2023

Conversation

wazsone
Copy link
Contributor

@wazsone wazsone commented May 16, 2023

Contribution checklist

Brief description

image image

Related issues

https://front.hc.engineering/workbench/platform/tracker/UBER-118

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

@wazsone
forbid to create workspaces with # and ! in a name
52a28fb 
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
@wazsone wazsone self-assigned this May 16, 2023
@wazsone
forbid unwanted symbols in a workspace name
a9defcf 
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
@wazsone wazsone changed the title [UBER-118] Forbid to create workspaces with # and ! in a name [UBER-118] Forbid unwanted symbols in a workspace name May 16, 2023
@wazsone wazsone requested a review from haiodo May 16, 2023 12:52
@haiodo haiodo merged commit 72f1570 into main May 17, 2023
7 checks passed
@haiodo haiodo deleted the UBER-118/workspace-name branch May 17, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

@BykhovDenis BykhovDenis BykhovDenis approved these changes

Assignees

@wazsone wazsone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wazsone @haiodo @BykhovDenis