Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-48: custom fields for organization in leads #3203

Merged
merged 4 commits into from May 19, 2023
Merged

UBER-48: custom fields for organization in leads #3203

merged 4 commits into from May 19, 2023

Conversation

ThetaDR
Copy link
Member

@ThetaDR ThetaDR commented May 17, 2023

Contribution checklist

Brief description

image

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

https://front.hc.engineering/workbench/platform/tracker/UBER-48

A list of closed updated issues

@ThetaDR
UBER-76: Add custom fields for organization customers in Leads
c06999f 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
UBER-76: side-fix - fixed no margins in create organization in contacts
0ef4d40 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
UBER-48: actually set custom fields for the created object
3e6d7fe 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
UBER-48: formatter fix
be30135 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@haiodo haiodo merged commit 88d62bc into main May 19, 2023
6 of 7 checks passed
@haiodo haiodo deleted the UBER-48 branch May 19, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ThetaDR @haiodo