Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBER-159: popup dialog for deleting with message if not enough permissions #3224

Merged
merged 3 commits into from May 23, 2023

Conversation

ThetaDR
Copy link
Member

@ThetaDR ThetaDR commented May 19, 2023

Contribution checklist

Brief description

image

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

https://front.hc.engineering/workbench/platform/tracker/UBER-159
A list of closed updated issues

…sions

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested a review from haiodo May 19, 2023 16:27
@haiodo
Copy link
Member

haiodo commented May 19, 2023

I think it should be like this:

Title: Not enough permissions to delete document.

Message: Please contact the author {Name} or workspace authorised employees: {List}

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@haiodo haiodo merged commit 14fbe03 into main May 23, 2023
7 checks passed
@haiodo haiodo deleted the UBER-159 branch May 23, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants