Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UBER-82] Update components #3227

Merged
merged 5 commits into from May 22, 2023
Merged

[UBER-82] Update components #3227

merged 5 commits into from May 22, 2023

Conversation

wazsone
Copy link
Contributor

@wazsone wazsone commented May 21, 2023 •
edited

Contribution checklist

Brief description

  • Component selector for an Issue should take components from a Project
  • On click on Component, it should open it with regular editor
  • Remove status
  • Remove start/target dates
  • Remove members

Related issues

https://front.hc.engineering/workbench/platform/tracker/UBER-82

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

@wazsone
component selector for the issue should take components from its project
b9637d5 
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
@wazsone
open edit doc for components
d1e3d20 
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
@wazsone
remove status, start/target dates, members from components
2cbe070 
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
@wazsone wazsone self-assigned this May 21, 2023
@wazsone wazsone changed the title Uber 82/components [UBER-82] Update components May 21, 2023
@wazsone wazsone marked this pull request as draft May 21, 2023 12:18
@wazsone
update components test
ebf14c5 
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
@wazsone
remove components timeline
2b362f0 
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
haiodo
haiodo approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@haiodo haiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, next step will be to use aggregation. Let's do it in next PR.

@wazsone wazsone marked this pull request as ready for review May 22, 2023 05:00
@wazsone
Copy link
Contributor Author

wazsone commented May 22, 2023

Looks good, next step will be to use aggregation. Let's do it in next PR.

@haiodo Sure

@haiodo haiodo merged commit 2f4cb2c into main May 22, 2023
7 checks passed
@haiodo haiodo deleted the UBER-82/components branch May 22, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

@BykhovDenis BykhovDenis Awaiting requested review from BykhovDenis

Assignees

@wazsone wazsone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wazsone @haiodo