UBER-148: My Applications in recruit #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lugins Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
haiodo
reviewed
May 22, 2023
| import { Viewlet } from '@hcengineering/view' | ||
| import { FilterButton, setActiveViewletId } from '@hcengineering/view-resources' | ||
| import tracker from '../../plugin' | ||
| import { WithLookup } from '@hcengineering/core' | ||
| import ModeSelector from '../ModeSelector.svelte' | ||
| import { IModeSelector } from '../../utils' | ||
| import ModeSelector from '@hcengineering/ui/src/components/ModeSelector.svelte' |
There was a problem hiding this comment.
Please use export and proper import
haiodo
reviewed
May 22, 2023
| @@ -60,8 +85,54 @@ | |||
| ).values() | |||
| ) | |||
| }) | |||
| const subscribedQuery = createQuery() | |||
| $: subscribedQuery.query( | |||
There was a problem hiding this comment.
May be we should query only if selected?
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
haiodo
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution checklist
Brief description
Checklist
Related issues
https://front.hc.engineering/workbench/platform/tracker/UBER-148
A list of closed updated issues