Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-47: attributes for base class (ex. contacts in lead's customers) #3241

Merged
merged 1 commit into from May 24, 2023
Merged

UBER-47: attributes for base class (ex. contacts in lead's customers) #3241

merged 1 commit into from May 24, 2023

Conversation

ThetaDR
Copy link
Member

@ThetaDR ThetaDR commented May 23, 2023 •
edited

Contribution checklist

Brief description

Fix for no custom attributes in filters

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

https://front.hc.engineering/workbench/platform/tracker/UBER-47
A list of closed updated issues

@ThetaDR
UBER-47: attributes for base class (ex. contacts in lead's customers)
4a2cb1c 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested a review from haiodo May 23, 2023 18:04
@BykhovDenis BykhovDenis merged commit 6773c0d into main May 24, 2023
7 checks passed
@BykhovDenis BykhovDenis deleted the UBER-47 branch May 24, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BykhovDenis BykhovDenis BykhovDenis approved these changes

@haiodo haiodo Awaiting requested review from haiodo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ThetaDR @BykhovDenis