Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UBER-129] Fix list scroll #3334

Merged
merged 4 commits into from
Jun 5, 2023
Merged

[UBER-129] Fix list scroll #3334

merged 4 commits into from
Jun 5, 2023

Conversation

wazsone
Copy link
Contributor

@wazsone wazsone commented Jun 2, 2023

Contribution checklist

Related issues

https://front.hc.engineering/workbench/platform/tracker/UBER-129

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

@wazsone
fix list scroll jumps on category collapse
15d0b08 
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
@wazsone
remove unused bind
da913ee 
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
@wazsone
fix scroll jump from the middle
702022f 
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
@wazsone wazsone self-assigned this Jun 2, 2023
@haiodo haiodo merged commit 55864db into main Jun 5, 2023
7 checks passed
@haiodo haiodo deleted the UBER-129/fix-list-scroll branch June 5, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

@BykhovDenis BykhovDenis Awaiting requested review from BykhovDenis

Assignees

@wazsone wazsone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wazsone @haiodo