Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBERF-4526: Elastic bulk error on re-indexing #4155

Merged
merged 4 commits into from
Dec 7, 2023
Merged

UBERF-4526: Elastic bulk error on re-indexing #4155

merged 4 commits into from
Dec 7, 2023

Conversation

mixerka
Copy link
Contributor

@mixerka mixerka commented Dec 6, 2023

Contribution checklist

Brief description

The error we have is "Limit of total fields [1000] has been exceeded while adding new fields [1]". Added this text to error log to make such errors visible.

This is happens in index with a lot of custom fields and is about the amount off custom field names we have overall in one elastic index among all the elastic documents.

Although it is possible just to increase this limit, I would rather prefer not to do that due to performance risks.
And because we do not use actual field name in searching or filtering I suggest to move from field names like 638611f18894c91979399ef3%Источник_6386125d8894c91979399eff to have one custom attribute field and have all custom fields there as nested label-value objects.

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svele-check is applied (rush svelte check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka mixerka requested a review from haiodo December 6, 2023 19:59
@haiodo haiodo self-assigned this Dec 7, 2023
@haiodo haiodo merged commit 3df1f1d into main Dec 7, 2023
7 checks passed
@haiodo haiodo deleted the UBERF-4526 branch December 7, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants