Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBERF-6001: Roles management #4994

Merged
merged 16 commits into from
Mar 27, 2024
Merged

UBERF-6001: Roles management #4994

merged 16 commits into from
Mar 27, 2024

Conversation

lexiv0re
Copy link
Contributor

@lexiv0re lexiv0re commented Mar 15, 2024

Contribution checklist

Brief description

  • Adds SpaceType
  • Moves ProjectType and TaskType to the model
  • Updates ProjectType configuration UI to also add/configure space types which are not project types
  • Adds trivial roles configuration to the space type UI
  • Adds members to roles assignment UI to create/edit spaces/projects in tracker/recruiting/wiki/funnels
  • Adds trivial permissions
  • Check "Delete" permission for objects within the spaces where roles and permissions can now be configured (UI + Middleware)
NewType Writer DocSpace

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svelte-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

https://front.hc.engineering/workbench/platform/tracker/UBERF-6001

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

View in Huly UBERF-6048

@lexiv0re lexiv0re force-pushed the uberf-6001/roles-management branch 2 times, most recently from ab3feb2 to 52e87df Compare March 19, 2024 14:46
@lexiv0re lexiv0re changed the title UBERF-6001: Roles management [Preview] UBERF-6001: Roles management [Part I] Mar 19, 2024
@lexiv0re lexiv0re force-pushed the uberf-6001/roles-management branch from 899e7c9 to d82e30c Compare March 20, 2024 16:55
@lexiv0re
Copy link
Contributor Author

@anotherpit cc

@lexiv0re lexiv0re force-pushed the uberf-6001/roles-management branch 2 times, most recently from 07e8e78 to 16ad557 Compare March 23, 2024 16:29
@lexiv0re lexiv0re changed the title UBERF-6001: Roles management [Part I] UBERF-6001: Roles management Mar 23, 2024
@lexiv0re lexiv0re marked this pull request as ready for review March 23, 2024 16:32
@lexiv0re lexiv0re force-pushed the uberf-6001/roles-management branch from 16ad557 to c8abba2 Compare March 26, 2024 12:27
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
…yped spaces

Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>

Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>

Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>

Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>

Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>

Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
@lexiv0re lexiv0re force-pushed the uberf-6001/roles-management branch from b77633c to a15244f Compare March 26, 2024 22:27
@BykhovDenis BykhovDenis merged commit 418b4b1 into main Mar 27, 2024
7 checks passed
@BykhovDenis BykhovDenis deleted the uberf-6001/roles-management branch March 27, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants