Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBERF-6209: add reactivity #5078

Merged
merged 3 commits into from
Mar 27, 2024
Merged

UBERF-6209: add reactivity #5078

merged 3 commits into from
Mar 27, 2024

Conversation

ThetaDR
Copy link
Member

@ThetaDR ThetaDR commented Mar 27, 2024

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svelte-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

View in Huly UBERF-6210

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested a review from haiodo March 27, 2024 12:14
BykhovDenis
BykhovDenis previously approved these changes Mar 27, 2024
haiodo
haiodo previously approved these changes Mar 27, 2024
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR dismissed stale reviews from haiodo and BykhovDenis via bf14b69 March 27, 2024 16:12
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@BykhovDenis BykhovDenis merged commit a5d51a7 into main Mar 27, 2024
7 checks passed
@BykhovDenis BykhovDenis deleted the UBERF-6209 branch March 27, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants