Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance: fix Show BTS within distance query, parameter validation, refactor code, update README #165

Merged
merged 3 commits into from
May 8, 2024

Conversation

hch155
Copy link
Owner

@hch155 hch155 commented May 8, 2024

Fix Show BTS within distance query in app.py

  • When a valid max_distance is provided, limit is automatically set to None. This prioritizes distance-based queries, facilitating a broader overview of base stations within a specified range

Parameter validation in app.py

Added validation checks to ensure:

  • max_distance falls within 0.1 to 10 km,
  • limit does not exceed 10,

preventing unrealistic range queries that could affect performance / exploit app and the responses are within expected data thresholds.

Refactor code in queries.py

  • remove redundant duplicate line that sorted final_stations_list

Update README

  • add application URL

@hch155 hch155 merged commit 8bd396b into main May 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant