Improved 'direct method' for converting contours to meshes #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds functionality to compare meshes based on Hausdorff distance and surface area
* add conic box issue * add correspondence issue * add more shapes
* added vol comparison to script * added calculations of centroids and centroid shift * fixed volmue calc err * addressed comments on PR * fixed typo * another typo fixed, spacing fixed * corrected variable name * added some spacing * added spacing * typo fix
* implementation based on overlap and enclosure * fixed bug with intersection logic * removed debugging statements * added break
Create custom contours
* CI: GitHub: work around dir ownership. For some reason the ownership of the root repo dire is not owned by the current user. (Maybe to make it de-facto read-only? Or maybe an artifact of containerization? Something else?) This commit silences git warnings about ownership that would otherwise result in irrelevant fatal errors. * CI: GitHub: tweak dir ownership workaround. Not sure which build stages / enviornments actually need this workaround. Either way, defer until git package has been explicitly installed. * initial changes to add higher plane * switch from pairings to pairs * add set removal * initial try * final before new simple try * almost there * done * clean up * simplified a lot * final final clean * add boolean --------- Co-authored-by: Haley Clark <gmail.com@hdeanclark> Co-authored-by: Hal Clark <haley.clark@bccancer.bc.ca>
…en meshes in pathalogical cases (#12) * Upgraded CreateCustomContour * Fixed N-to-N bug which results open meshes in some pathalogical cases * Changed Namespace * Updated Docs
* check areas * attempting capping and tiling * bug fix * handled one-to-two case * two-to-two case * compiles * commented outer tiling for debugging * tried some test shapes * changed capping of pipe like structures * bug fix * removed redundant code * removed log statements * removed more log statements * addressed comments from PR * fixed spacing * fixed spacing * more changes from PR
* Started graph approach * Added graph construction and conversion back to index list * Added recursive graph search * Finished tenetative graph implementation * Fixed graph search specific bugs * Fixed indexing issues * Got tiling working for big contours * Got tiling working on large shapes * Cleaned up code for PR * Addressed PR comments * Fixed indexing issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR for the work done by capstone group 2300. The project goal was to implement algorithms to convert contours into surface meshes. A brief summary of the changes made is as follows: