Two to one branching #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiffanymatthe
force-pushed
the
two_to_one_branching
branch
2 times, most recently
from
953c478
to
72dba53
Compare
Renu-R
reviewed
Apr 9, 2023
| //The rotation matrix R that rotates the contour normal to the direction of | ||
| //the z-axis can be applied to all the contour points to move them to the XY plane | ||
| auto unitNormContour = cont_normal.unit(); | ||
|
|
For some reason the ownership of the root repo dire is not owned by the current user. (Maybe to make it de-facto read-only? Or maybe an artifact of containerization? Something else?) This commit silences git warnings about ownership that would otherwise result in irrelevant fatal errors.
Not sure which build stages / enviornments actually need this workaround. Either way, defer until git package has been explicitly installed.
tiffanymatthe
force-pushed
the
two_to_one_branching
branch
from
851aa7f
to
480138b
Compare
misprit7
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test cases:
bcb52a86-650c-4704-b006-944b747e3ec2_2_to_1_Meshing_Logs.pdf