Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup GitHub Actions/Pipelines for automatic CI #10

Closed
oruebel opened this issue Aug 11, 2022 · 3 comments
Closed

Setup GitHub Actions/Pipelines for automatic CI #10

oruebel opened this issue Aug 11, 2022 · 3 comments
Assignees
@mavaylon1
Labels
priority: critical impacts proper operation or use of core function of NWB or the software topic: continuous integration issues related to CI and repository management

Comments

@oruebel
Copy link
Contributor

oruebel commented Aug 11, 2022 •
edited
Loading

Similar to the main HDMF we should run the following all pull requests

For this we can most likely build off the workflows defined in HDMF https://github.com/hdmf-dev/hdmf/tree/dev/.github/workflows
@oruebel oruebel mentioned this issue Aug 11, 2022
Closed
@bendichter
Copy link
Contributor

+1 for black. See how we set it up here:

https://github.com/NeurodataWithoutBorders/nwbinspector/blob/803756995f84d04bf543c85fb1684961e6290643/.pre-commit-config.yaml

https://github.com/NeurodataWithoutBorders/nwbinspector/blob/60e081c68710308c05a48f6b2211480b38e98589/pyproject.toml

https://github.com/NeurodataWithoutBorders/nwbinspector/blob/bac7056cc5f2c61a1444b5a6c8a9e990a5c26b4c/.github/workflows/black.yml

@oruebel oruebel added priority: high impacts proper operation or use of feature important to most users topic: continuous integration issues related to CI and repository management labels Aug 11, 2022
@oruebel
Copy link
Contributor Author

oruebel commented Aug 12, 2022 •
edited
Loading

+1 for black

👍 I have not used black before, but I won't stand in the way of progress 😉

@mavaylon1 mavaylon1 added priority: critical impacts proper operation or use of core function of NWB or the software and removed priority: high impacts proper operation or use of feature important to most users labels Aug 16, 2022
@mavaylon1 mavaylon1 mentioned this issue Aug 16, 2022
Merged
@oruebel
Copy link
Contributor Author

oruebel commented Aug 19, 2022

Fixed in #32

@oruebel oruebel closed this as completed Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mavaylon1 mavaylon1

Labels
priority: critical impacts proper operation or use of core function of NWB or the software topic: continuous integration issues related to CI and repository management
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bendichter @oruebel @mavaylon1