-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create workflows #32
Create workflows #32
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #32 +/- ##
======================================
Coverage ? 81.24%
======================================
Files ? 10
Lines ? 2458
Branches ? 0
======================================
Hits ? 1997
Misses ? 461
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This looks good to me. @rly could you review this PR since you are more familiar with the CI. |
pre-commit: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These actions have newer versions. Can you update these?
I recommend keeping |
@oruebel So the the gallery tests for 3.7 minimum are using an older version of dandi. I've tried to set a dandi minimum version but that breaks other parts.
For more details: checkout commit df51116 Any thoughts? This is for the doc "plot_convert_nwb.py" line 19 showing an error in the init that seems to be fixed in newer dandi versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
No description provided.