Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create workflows #32

Merged
merged 33 commits into from
Aug 19, 2022
Merged

Create workflows #32

merged 33 commits into from
Aug 19, 2022

Conversation

mavaylon1
Copy link
Contributor

No description provided.

@mavaylon1
Copy link
Contributor Author

mavaylon1 commented Aug 16, 2022

Fix #18, #10 , #11

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022

Codecov Report

❗ No coverage uploaded for pull request base (dev@c7f9c0c). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev      #32   +/-   ##
======================================
  Coverage       ?   81.24%           
======================================
  Files          ?       10           
  Lines          ?     2458           
  Branches       ?        0           
======================================
  Hits           ?     1997           
  Misses         ?      461           
  Partials       ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

docs/source/overview.rst Outdated Show resolved Hide resolved
@mavaylon1 mavaylon1 requested a review from oruebel August 18, 2022 17:39
@oruebel oruebel requested a review from rly August 18, 2022 17:46
docs/source/overview.rst Outdated Show resolved Hide resolved
test.py Outdated Show resolved Hide resolved
@oruebel
Copy link
Contributor

oruebel commented Aug 18, 2022

This looks good to me. @rly could you review this PR since you are more familiar with the CI.

pre-commit:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These actions have newer versions. Can you update these?

@rly
Copy link
Contributor

rly commented Aug 18, 2022

I recommend keeping requirements-min.txt from HDMF and testing with it. They should mirror the minimum requirements set in setup.py. We should test those in the CI (please revert some of the changes where you removed py3.7-minimum)

@mavaylon1
Copy link
Contributor Author

mavaylon1 commented Aug 19, 2022

@oruebel So the the gallery tests for 3.7 minimum are using an older version of dandi. I've tried to set a dandi minimum version but that breaks other parts.
ex)
I added dandi>= 0.46.1 to the requirements-doc.txt which led to

  1. Run code coverage / macos-latest failing when it was passng prior.
  2. The same gallery 3.7 minimum tests failing but for a new reason. ----> "FileNotFoundError: [Errno 2] No such file or directory: 'requirements.txt' ".

For more details: checkout commit df51116

Any thoughts?

This is for the doc "plot_convert_nwb.py" line 19 showing an error in the init that seems to be fixed in newer dandi versions.

Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mavaylon1 mavaylon1 merged commit 0befe92 into dev Aug 19, 2022
@mavaylon1 mavaylon1 deleted the workflows branch August 19, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants