Add tests for #51 and fix (#54)

Inserting name as a positional arg in the first location can sometimes 
mess up other positional args because the docval args no longer list 
name as a positional arg

src/hdmf/build/map.py

@@ -1407,7 +1407,7 @@ def __get_cls_dict(self, base, addl_fields, name=None):
         def __init__(self, **kwargs):
             pargs, pkwargs = fmt_docval_args(base.__init__, kwargs)
             if name is not None:
-                pargs.insert(0, name)
+                pkwargs.update(name=name)
             base.__init__(self, *pargs, **pkwargs)
             for f in new_args:
                 setattr(self, f, kwargs.get(f, None))

tests/unit/build_tests/test_io_map.py

@@ -200,6 +200,42 @@ def test_dynamic_container_constructor(self):
         self.assertEqual(inst.attr3, 98.6)
         self.assertEqual(inst.attr4, 1.0)
 
+    def test_dynamic_container_constructor_name(self):
+        # name is specified in spec and cannot be changed
+        baz_spec = GroupSpec('A test extension with no Container class',
+                             data_type_def='Baz', data_type_inc=self.bar_spec,
+                             name='A fixed name',
+                             attributes=[AttributeSpec('attr3', 'an example float attribute', 'float'),
+                                         AttributeSpec('attr4', 'another example float attribute', 'float')])
+        self.spec_catalog.register_spec(baz_spec, 'extension.yaml')
+        cls = self.type_map.get_container_cls(CORE_NAMESPACE, 'Baz')
+
+        with self.assertRaises(TypeError):
+            inst = cls('My Baz', [1, 2, 3, 4], 'string attribute', 1000, attr3=98.6, attr4=1.0)
+
+        inst = cls([1, 2, 3, 4], 'string attribute', 1000, attr3=98.6, attr4=1.0)
+        self.assertEqual(inst.name, 'A fixed name')
+        self.assertEqual(inst.data, [1, 2, 3, 4])
+        self.assertEqual(inst.attr1, 'string attribute')
+        self.assertEqual(inst.attr2, 1000)
+        self.assertEqual(inst.attr3, 98.6)
+        self.assertEqual(inst.attr4, 1.0)
+
+    def test_dynamic_container_constructor_name_default_name(self):
+        # if both name and default_name are specified, name should be used
+        with self.assertWarns(Warning):
+            baz_spec = GroupSpec('A test extension with no Container class',
+                                 data_type_def='Baz', data_type_inc=self.bar_spec,
+                                 name='A fixed name',
+                                 default_name='A default name',
+                                 attributes=[AttributeSpec('attr3', 'an example float attribute', 'float'),
+                                             AttributeSpec('attr4', 'another example float attribute', 'float')])
+            self.spec_catalog.register_spec(baz_spec, 'extension.yaml')
+            cls = self.type_map.get_container_cls(CORE_NAMESPACE, 'Baz')
+
+            inst = cls([1, 2, 3, 4], 'string attribute', 1000, attr3=98.6, attr4=1.0)
+            self.assertEqual(inst.name, 'A fixed name')
+
 
 class TestObjectMapper(with_metaclass(ABCMeta, unittest.TestCase)):