Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add dimension scales/coordinates #192

Draft
wants to merge 79 commits into
base: dev
Choose a base branch
from
Draft

[WIP] Add dimension scales/coordinates #192

wants to merge 79 commits into from

Conversation

rly
Copy link
Contributor

@rly rly commented Nov 6, 2019

Add dimension scales/coordinates to support direct association of datasets with dimensions of other datasets within a group. See NeurodataWithoutBorders/pynwb#626

Very much a work in progress. I am also taking the opportunity to comment and refactor src/hdmf/build/map.py. ObjectMapper is now in its own 1000-line file. Unfortunately, the refactoring obscures the changes I made in the ObjectMapper.

@codecov
Copy link

codecov bot commented Nov 13, 2019

Codecov Report

❗ No coverage uploaded for pull request base (dev@c98e32b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev     #192   +/-   ##
======================================
  Coverage       ?   71.03%           
======================================
  Files          ?       32           
  Lines          ?     6279           
  Branches       ?     1468           
======================================
  Hits           ?     4460           
  Misses         ?     1367           
  Partials       ?      452

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c98e32b...1092746. Read the comment docs.

@rly
Copy link
Contributor Author

rly commented Apr 11, 2024

TODO: Add support for auto-checking dims in auto-generated classes: NeurodataWithoutBorders/pynwb#480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant