Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add citation information to README and readthedocs #477

Merged
merged 3 commits into from
Nov 30, 2020
Merged

Add citation information to README and readthedocs #477

merged 3 commits into from
Nov 30, 2020

Conversation

rly
Copy link
Contributor

@rly rly commented Nov 25, 2020

Motivation

See #476 (comment)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

oruebel
oruebel previously approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to just close the PR I had just added for this and merge this one instead.

@rly
Copy link
Contributor Author

rly commented Nov 25, 2020

I just saw your PR. Providing the bibtex is probably better. I'll update this in a second.

@rly rly requested a review from oruebel November 25, 2020 18:10
@rly rly merged commit df96407 into dev Nov 30, 2020
@rly rly deleted the docs/citation branch November 30, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oruebel oruebel oruebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rly @oruebel