Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle pie executables on Linux #59

Merged
merged 4 commits into from
Jul 28, 2020
Merged

Handle pie executables on Linux #59

merged 4 commits into from
Jul 28, 2020

Conversation

bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Jul 28, 2020

Fixes #51

@bjorn3 bjorn3 requested a review from nbaksalyar July 28, 2020 14:43
@bjorn3 bjorn3 mentioned this pull request Jul 28, 2020
Merged
4 tasks
nbaksalyar
nbaksalyar reviewed Jul 28, 2020
View reviewed changes
Copy link
Member

@nbaksalyar nbaksalyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few nitpicks which can be addressed later.

src/target/unix.rs Outdated Show resolved Hide resolved
src/target/mod.rs Show resolved Hide resolved
src/symbol/mod.rs
@@ -277,3 +280,132 @@ impl Dwarf {
self.rent(|parsed| parsed.get_var_address(name))
}
}

pub struct RelocatedDwarf(Vec<RelocatedDwarfEntry>);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This struct probably can be moved into its own module, but can be done later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do this later.

@bjorn3 @nbaksalyar
Add ADDR_NO_RANDOMIZE const
ab462fc 
Co-authored-by: Nikita Baksalyar <nikita.baksalyar@gmail.com>
@nbaksalyar
Copy link
Member

It also seems that this const is missing in rust-lang/libc, I'm going to raise a PR for that :)

Raised rust-lang/libc#1849

nbaksalyar
nbaksalyar approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@nbaksalyar nbaksalyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@bjorn3 bjorn3 merged commit 504791a into headcrab-rs:master Jul 28, 2020
@bjorn3 bjorn3 deleted the give_me_a_pie branch July 28, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbaksalyar nbaksalyar nbaksalyar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle PIE executables on Linux by reading mem maps
2 participants
@bjorn3 @nbaksalyar