Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use bow.state.Response.Request.URL in Url() #18

Merged
merged 1 commit into from
Apr 28, 2015
Merged

Change to use bow.state.Response.Request.URL in Url() #18

merged 1 commit into from
Apr 28, 2015

Conversation

lestrrat
Copy link
Contributor

Prefer to use bow.state.Response.URL, because in case of redirects,
the current context depends on the final Request.

A concrete example would be something like OAuth flow, where you
access host A which delegates to host B to do the authorization
via a redirect. If you don't use the Response URL, then the next
Form object may resolve its URL in the context of host A, not B

Prefer to use bow.state.Response.URL, because in case of redirects,
the current context depends on the final Request.

A concrete example would be something like OAuth flow, where you
access host A which delegates to host B to do the authorization
via a redirect. If you don't use the Response URL, then the next
Form object may resolve its URL in the context of host A, not B
@headzoo headzoo merged commit 73c084e into headzoo:dev Apr 28, 2015
@headzoo
Copy link
Owner

headzoo commented Apr 28, 2015

This has been merged into dev, which I'll merge into master later today. Thanks for the contribution, and thank you for taking the time to write a test for your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants