Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to make Gaussian blm consistent #885

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mreineck
Copy link
Member

@mreineck mreineck commented Sep 4, 2023

Fixes #861

I'd love to get some independent opinions on this, especially on the normalization factor for the polarised components.

@hivon, do you think this is the right expression?

@mreineck
Copy link
Member Author

mreineck commented Sep 4, 2023

Regression test currently fails, because I'm comparing against hardcoded arrays. I'll adjust those once we have converged to the right formula.

@zonca
Copy link
Member

zonca commented Oct 13, 2023

@mreineck what about writing a unit test that uses both this and blm_gauss to show that they are consistent?
@hivon any feedback on this?

@hivon
Copy link

hivon commented Oct 13, 2023

Unit tests are always a good idea.
@zonca, @mreineck I enclose below my reply from Sep 4 about the numerical factors

-------- Forwarded Message --------
Subject: Re: [healpy/healpy] Try to make Gaussian blm consistent (PR #885)
Date: Mon, 4 Sep 2023 14:29:24 +0200
From: Eric Hivon hivon@iap.fr
To: reply+ABKVQDMCLQKEQUOTOD7QXQODALZ6HEVBNHHHAD7NIU@reply.github.com

Hi @mreineck,
this is the factor I use for E and B beams, based on the Challinor et al paper.
While it matters for theoretical studies, it won't matter as much for data analysis, where
the temperature and polarization gains and beams are calibrated separately.

Cheers,
Eric

On 04/09/2023 13:37, mreineck wrote:

Fixes #861 #861

I'd love to get some independent opinions on this, especially on the normalization factor for the polarised components.

@hivon https://github.com/hivon, do you think this is the right expression?


    You can view, comment on, or merge this pull request online at:

#885

    Commit Summary

(1 file https://github.com/healpy/healpy/pull/885/files)


Reply to this email directly, view it on GitHub #885, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKVQDNKSDULNGYRLD3KQT3XYW4OHANCNFSM6AAAAAA4KJDASY.
You are receiving this because you were mentioned.Message ID: healpy/healpy/pull/885@github.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sphtfunc.blm_gauss() is not consistent with the rest of healpy
3 participants