Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use project's code in URLs, reduce the use of Profile.current_project #336

Closed
cuu508 opened this issue Feb 21, 2020 · 0 comments
Closed

Use project's code in URLs, reduce the use of Profile.current_project #336

cuu508 opened this issue Feb 21, 2020 · 0 comments

Comments

@cuu508
Copy link
Member

cuu508 commented Feb 21, 2020

Some URLs already contain project's code:

/projects/<project-code>/checks/
/projects/<project-code>/badges/
/projects/<project-code>/settings/

Some don't:

/integrations/
/integrations/add_email/
/integrations/add_slack/
...

In these views, we look up the current project from the Profile.current_project field. This can cause confusion when multiple projects are open in multiple tabs.

I'd like to reduce the usage of Profile.current_project as much as possible. This should probably be done incrementally in small steps, not as a big overhaul.
cuu508 added a commit that referenced this issue Feb 21, 2020
@cuu508
Project code in URL for the "Integrations" and the "Add Email" pages.…
ea423e5 
… cc: #336
cuu508 added a commit that referenced this issue Feb 21, 2020
@cuu508
Project code in URL for the "Add Webhook" page. cc: #336
59f5b7a
cuu508 added a commit that referenced this issue Feb 21, 2020
@cuu508
Project code in URL for the "Add Matrix" page. cc: #336
f8758e3
cuu508 added a commit that referenced this issue Feb 21, 2020
@cuu508
Project code in URL for the "Add Mattermost" page. cc: #336
70ff6c5
cuu508 added a commit that referenced this issue Feb 21, 2020
@cuu508
Project code in URL for the "Add MS Teams" page. cc: #336
d0b77fe
cuu508 added a commit that referenced this issue Feb 21, 2020
@cuu508
Project code in URL for the "Add OpsGenie" page. cc: #336
a6d497b
cuu508 added a commit that referenced this issue Feb 21, 2020
@cuu508
Project code in URL for the "Add Pagerteam" page. cc: #336
0ea2369
cuu508 added a commit that referenced this issue Feb 21, 2020
@cuu508
Project code in URL for the "Add Pagertree" page. cc: #336
5fb5b05
cuu508 added a commit that referenced this issue Feb 21, 2020
@cuu508
Project code in URL for the "Add Prometheus" page. cc: #336
f6a7d46
cuu508 added a commit that referenced this issue Feb 21, 2020
@cuu508
Project code in URL for the "Add SMS" page. cc: #336
2509350
cuu508 added a commit that referenced this issue Feb 21, 2020
@cuu508
Project code in URL for the "Add VictorOps" page. cc: #336
9f5c133
cuu508 added a commit that referenced this issue Feb 21, 2020
@cuu508
Project code in URL for the "Add WhatsApp" page. cc: #336
056134f
cuu508 added a commit that referenced this issue Feb 21, 2020
@cuu508
Project code in URL for the "Add Apprise" page. cc: #336
88f2a01
cuu508 added a commit that referenced this issue Feb 21, 2020
@cuu508
Project code in URL for the "Add Shell" page. cc: #336
81f9a60
cuu508 added a commit that referenced this issue Feb 21, 2020
@cuu508
Project code in URL for the "Add PagerDuty" page. cc: #336
44819cb
cuu508 added a commit that referenced this issue Feb 21, 2020
@cuu508
Project code in URL for the "Add Pushbullet" page. cc: #336
38bd84c
cuu508 added a commit that referenced this issue Feb 25, 2020
@cuu508
Project code in URL for the "Add Discord" page. cc: #336
f13ad87
cuu508 added a commit that referenced this issue Feb 25, 2020
@cuu508
Project code in URL for the "Add PagerDuty (Connect)" page. cc: #336
ea333f7
cuu508 added a commit that referenced this issue Feb 25, 2020
@cuu508
Project code in URL for the "Add Pushover" page. cc: #336
f6f2b18
cuu508 added a commit that referenced this issue Feb 25, 2020
@cuu508
Project code in URL for the "Add Trello" page. cc: #336
dee189b
cuu508 added a commit that referenced this issue Feb 25, 2020
@cuu508
Project code in URL for the "Add Slack" page. cc: #336
acce080
cuu508 added a commit that referenced this issue Feb 25, 2020
@cuu508
The "Add Telegram" page shows a project picker. cc: #336
7060d49
cuu508 added a commit that referenced this issue Feb 25, 2020
@cuu508
Reduce usage of request.project cc: #336
bb80885
cuu508 added a commit that referenced this issue Feb 26, 2020
@cuu508
Don't use request.project in the pricing page cc: #336
9c3f710
cuu508 added a commit that referenced this issue Feb 26, 2020
@cuu508
Reduce usage of Profile.current_project cc: #336
157711b
cuu508 added a commit that referenced this issue Feb 27, 2020
@cuu508
Profile.current_project not used any more, remove last remaining refe…
0c9c453 
…rences. cc: #336
@cuu508 cuu508 closed this as completed in 8bbf85a Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cuu508