-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Simplify OmniAuth version check by trying to load the gem with the ne…
…cessary version
- Loading branch information
1 parent
c43ae8c
commit 1d138dd
Showing
1 changed file
with
2 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d138dd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using
I still get this error
1d138dd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol I was using the last release of devise from September.
To make it work:
1d138dd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yshmarov correct, we don't have a new release yet containing these changes for OmniAuth. :) Hopefully it all works well with master.
1d138dd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does work well with master
1d138dd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pegging the version to master works for me as well.
I couldn't find it, but is there an anticipated date for the next officially tagged release after v4.7.3?
I'm a little nervous pegging a version to the master branch in production since it seems possible it will change on me during builds.
Any recommendations on how to best mitigate any possible issues going this route would be appreciated!
Thanks!
1d138dd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamlutz when you lock your bundle to master or any branch, it will lock it to a specific commit at that moment in time, and should continue using the same commit going forward. It shouldn't update from under you, unless you remove the lock file or run bundle update.
I'm looking into a possible new release, but have a few other things I want to get included before I can bump it to a 4.8 or something. Hopefully soon.
1d138dd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1d138dd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed v4.8 including this change, please give it a try and report back if you have any issues. Thanks.
1d138dd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed: the error is gone after
bundle update devise
.1d138dd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like upgrading devise gem working in local environment, but on deployment build seems to be failing with the following reason
Error: buildx failed with: error: failed to solve: executor failed running [/bin/sh -c gem install bundler --no-document && bundle config --local path $BUNDLE_PATH && bundle config set without 'profile development test' && bundle config set deployment 'true' && bundle install -j $(nproc)]: exit code: 16
not sure what other steps are we supposed to do for this issue?
gem 'omniauth', '~> 2.0.2'
and devise gem version is 4.8.1