Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Rails 6.0.0.rc1 #5085

Closed
wants to merge 1 commit into from
Closed

Conversation

jtapia
Copy link

@jtapia jtapia commented Jun 6, 2019

No description provided.

@@ -22,6 +22,6 @@ Gem::Specification.new do |s|
s.add_dependency("warden", "~> 1.2.3")
s.add_dependency("orm_adapter", "~> 0.1")
s.add_dependency("bcrypt", "~> 3.0")
s.add_dependency("railties", ">= 4.1.0", "< 6.0")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

< 6.0 already support Rails 6.0.0.rc1. Why did you have to change this?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting this when I try edge devise:

Bundler could not find compatible versions for gem "railties":
  In Gemfile:
    devise was resolved to 4.6.2, which depends on
      railties (>= 4.1.0, < 6.0)

    rails was resolved to 6.1.0.alpha, which depends on
      railties (= 6.1.0.alpha)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that change because of an issue that I'm seeing using Rails 6.0.0.rc1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well @jasnow, you are trying to using devise with 6.1.0.alpha, but the current code works with 6.0.0.rc1.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that change because of an issue that I'm seeing using Rails 6.0.0.rc1

Can you post here the error you are getting?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that I have expanded the scope of this issue (to Rails 6.1.x) - sorry - verified that Rails 6.0.0.rc1 works with devise for both of my "problem" repos. I will watch for Rails 6.1.x work on devise to comment further. Thanks for all of ya'll work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants