Officially support Rails 6.0 #5086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove upper bound on railties so people can try devise with new versions without having to wait us to change the gem and report bugs.
tegon
approved these changes
Jun 18, 2019
There was a problem hiding this comment.
@rafaelfranca It seems good to me!
One thing that I found strange is the files lib/devise.rb, lib/generators/templates/devise.rb, test/devise_test.rb are appearing in the diff with 'No changes'. Do you know why that's happening?
|
Yeah. There were in the repository with the "execution flag" in the filesystem (100755 → 100644 in the diff). I fixed it. |
shimbaco
added a commit
to annict/annict
that referenced
this pull request
Jun 22, 2019
Officially support Rails 6.0: heartcombo/devise#5086
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove upper bound on railties so people can try devise with new versions without having to wait us to change the gem and report bugs.
Closes #5037
Closes #5085