-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated ActiveSupport::Dependencies.constantize fix #5397
Deprecated ActiveSupport::Dependencies.constantize fix #5397
Conversation
Can confirm this branch works when using an app based off of Rails |
tagging @carlosantoniodasilva @tegon |
Appreciate the ping. I'm well aware of the Rails 7 release timeline (final is still weeks/months away) and that Devise is currently not working with it at all, this being part of the necessary changes. (Turbo being another key piece.) I was waiting for things to play out further before making any changes to Devise to accommodate Rails master (watching things from a distance), plus I haven't had much time and energy to be honest. In any case, now that the alpha was released it does make it a bit more pressing, I'll find some time to get things lined up on this side soon. Thanks. |
For a while due to this PR not yet merged, if you interest to use devise in rails 7 you can add / change the line in
Edited:
|
It would be really useful to have this merged... ;) we're starting a new project now and we would like to use Rails 7 directly. |
@rafaelfranca if you get a chance, this PR fixes the issue for Rails 7 and would be great to have merged soon. 👍 |
I am going to work on this early next week. |
Thanks @carlosantoniodasilva! If there's anything we can do to help, let us know. 👍 |
I'm merging this to a separate branch for the time being, and will get it into master soon. Thanks @strobilomyces and everyone else here. |
This is now on master, thanks again. Side note: there's one warning triggered by the tests that I have to look into, I think it's Rails related, I'll circle back on it. |
Yeay Due to It is merged Already, for Rails 7 change your gemfile now to
Note: I have test it and run perfectly in Rails 7 Thanks !!! |
I believe it's suppose to be: |
thanks updated! |
undefined method `user_url' for #Devise::RegistrationsController:0x0000000000ef10 |
ActiveSupport::Dependencies.constantize(model_name) was deprecated in rails/main in favor of model_name.constantize