Delete AS::Dependencies.(safe_)constantize #43058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 20, 2021
stephenbinns
added a commit
to gocardless/coach
that referenced
this pull request
Sep 17, 2021
This is removed in rails 7 due to the classic autoloader being removed - see rails/rails#43058 for details.
stephenbinns
added a commit
to gocardless/coach
that referenced
this pull request
Sep 17, 2021
This is removed in rails 7 due to the classic autoloader being removed - see rails/rails#43058 for details.
stephenbinns
added a commit
to gocardless/coach
that referenced
this pull request
Sep 17, 2021
This is removed in rails 7 due to the classic autoloader being removed - see rails/rails#43058 for details.
stephenbinns
added a commit
to gocardless/coach
that referenced
this pull request
Sep 17, 2021
This is removed in rails 7 due to the classic autoloader being removed - see rails/rails#43058 for details.
tagliala
added a commit
to tagliala/activeadmin
that referenced
this pull request
Dec 14, 2021
tagliala
added a commit
to tagliala/activeadmin
that referenced
this pull request
Dec 14, 2021
tagliala
added a commit
to tagliala/activeadmin
that referenced
this pull request
Dec 14, 2021
tagliala
added a commit
to tagliala/activeadmin
that referenced
this pull request
Dec 17, 2021
tagliala
added a commit
to tagliala/activeadmin
that referenced
this pull request
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is part of the cleanup in
ActiveSupport::Dependenciesdue to the deletion ofclassic.)The methods
constantizeandsafe_constantizeofActiveSupport::Dependenciesare private. They have nothing to do with autoloading, just forward to the inflector. They were there for historical reasons, but today we no longer need them.The public interface is in
String. Soinstead of
The majority of the framework already did this, there were only a few occurrences.