Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap 3 support #28

Merged
merged 50 commits into from
Apr 4, 2014
Merged

Bootstrap 3 support #28

merged 50 commits into from
Apr 4, 2014

Conversation

rafaelfranca
Copy link
Collaborator

  • Install bootstrap 3 using bower
  • Review the header
  • Review the breadcrumb
  • Review the horizontal form
  • Review the comments form
  • Create a vertical form
  • Review the footer
  • Remove the vertical/horizontal toggle
  • Use Simple Form 3 generated initializers
  • Extract the wrappers configuration to Simple From
  • Add errors to example page

Closes #24 #26

Related

twbs/bootstrap#9067

@rafaelfranca
Install bootstrap 3 using bower
d4912b7
@rafaelfranca
Fix the header
2346d88
@rafaelfranca
Fix the breadcrumb
080ae43
@rafaelfranca
Fix the buttons in the form
4bd978a
@rafaelfranca
Use the right bootstrap classes
f8b0aba
@rafaelfranca
Better look for the label
7cd33a8
@rafaelfranca
Prepended inputs are not input groups
86094f3
@rafaelfranca
Make form look nicer
491a466
@rafaelfranca
Inplement boolean checkbox with normal Rails helpers
7d76738 
To Simple Form generate this we will need a lot of changes on Simple
Form code.

* Labels can't generate checkbox class by default
* Input can't use the form-control class configured globally
* Inline label has to be the default
@rafaelfranca
Copy link
Collaborator Author

Check boxes support is the first problem. I listed they at 7d76738

This was referenced Sep 22, 2013
Closed
Closed
Closed
Closed
@johnnyshields
Copy link

+1 👍 SimpleForm BS3 support is the last blocker for myself (and I suspect many others) to upgrade BS2->BS3

@ricardodovalle
Copy link

👍

@rafaelfranca rafaelfranca mentioned this pull request Oct 7, 2013
Closed
@vargeorge
Copy link

@rafaelfranca Thank you. Any thought when this may be available?

@rafaelfranca
Copy link
Collaborator Author

Unfortunately, no

@DanielKehoe DanielKehoe mentioned this pull request Oct 17, 2013
Closed
@rafaelfranca rafaelfranca mentioned this pull request Oct 24, 2013
Closed
@chipairon
Copy link

I have created a pull request to merge with this one if you find it appropriate that solves the problems I have found so far.

#30

Please, let me know if you like/agree with my approach and if it can be improved.

@caarlos0
Copy link

Meanwhile, any workaround for that?

@wtfiwtz
Copy link

wtfiwtz commented Oct 27, 2013

See this thread: heartcombo/simple_form#864
I also have a workaround I've been using successfully to date: https://github.com/wtfiwtz/simple_form_bootstrap3/commits/master

@caarlos0
Copy link

nice, thank you very much!

@Nerian
Copy link
Contributor

Nerian commented Nov 7, 2013

Hi @rafaelfranca ,

What's the state of Simpleform's bootstrap 3 integration? I recall there where some changes in the core simple_form that were necessary for supporting TW3 forms. Are those changes done? Is SF ready for supporting TW3?

I am particularly interested in full support for horizontal forms since that is what my website uses.

I will be available this weekend so I would like to spend some time improving SF support for TW3. Let me know what tasks need to be completed and where can I be of use.

Thanks.

@rafaelfranca
Copy link
Collaborator Author

Hi.

Simple Form still don't support Bootstrap 3. Nothing was did in the direction to make support to Bootstrap 3. I don't have time neither interest (I'm not a Bootstrap user) to work on it.

I'm hoping someone at Plataformatec will work on it, but I gladly can help someone else interested on work on it, but I don't think it will be an easy task, neither a quick one.

There are some requirements:

  • We can't change Simple Form to have any code specific for Bootstrap.
  • Custom Inputs are not a good solution too.
  • I still not convinced we need to support it. (This is why I created this branch).

Let me know if you want to help.

@johnnyshields
Copy link

@rafaelfranca I appreciate the work your team does, however lack of BS3 support in SimpleForm is becoming a major headache. Is there a list of outstanding gaps needed for BS3 support so we can finish it--clearly there is demand in the community?

@rafaelfranca
Copy link
Collaborator Author

@johnnyshields no, like I said I don't use Bootstrap so I even don't know what need to be supported. This is why I created this branch.

Feel free to investigate.

@Nerian
Copy link
Contributor

Nerian commented Nov 7, 2013

I understand. Makes total sense that you don't want to condition the design of SF just because of BS. There maybe changes though that must be done in SF in order to support Bootstrap 3, in such case – and if those changes don't make sense to be in core – I think I could just release those changes in a separate gem. Judging from the attention this issue gets, I don't think it will be a problem for us (me and interested parties) to maintain it.

Sounds good?

@aldesantis
Copy link

Thank you very much, this is some impressive work! :)

@mauriciomdea
Copy link

Nice work! Thank you very much!

@Vadorequest
Copy link

Looks really beautiful, well done!

@cicerobr
Copy link

cicerobr commented Apr 1, 2014

Oh god .. Nice job :)

@ricardodovalle
Copy link

Thanks @rafaelfranca, looks great 👍

@pedroandrade
Copy link

👍

@Nerian
Copy link
Contributor

Nerian commented Apr 1, 2014

Sweeeeeet 🍰

@phinfonet
Copy link

👍

@rafaelfranca
Copy link
Collaborator Author

@lucasmazza I removed the code pretty but maybe I'll add it back again. I change the application to have only one page, but I'm planning to work in a full documentation inside this application too.

Since I'm not sure when it will be done I removed the dependencies and I'll merge this branch as it is.

Thank you for the review.

@rafaelfranca
Copy link
Collaborator Author

Thank you for the support guys. ❤️

@lucasmazza
Copy link
Contributor

@rafaelfranca :shipit:

@volmer
Copy link

volmer commented Apr 1, 2014

Awesome!! 👏

@conzett
Copy link

conzett commented Apr 1, 2014

👍 Great work!

@luizrobertofreitas
Copy link

Parabéns, trabalho show de bola!!

rafaelfranca added a commit that referenced this pull request Apr 4, 2014
@rafaelfranca
Merge pull request #28 from rafaelfranca/rm-bootstrap-3
58f308a 
Bootstrap 3 support
@rafaelfranca rafaelfranca merged commit 58f308a into master Apr 4, 2014
@rafaelfranca rafaelfranca deleted the rm-bootstrap-3 branch April 4, 2014 18:04
@rafaelfranca rafaelfranca mentioned this pull request Apr 4, 2014
Closed
@linhmtran168
Copy link

Awesome!!! 👏 🎆

@jmuheim
Copy link

jmuheim commented Apr 8, 2014

Thanks a lot! 👍

@jmuheim
Copy link

jmuheim commented Apr 8, 2014

But how exactly do I use this? SimpleForm is still v3.0.1.

@andrielfn
Copy link

@jmuheim A new release of the gem will be available soon, until then, an option would be point the gem to master.

@jmuheim
Copy link

jmuheim commented Apr 8, 2014

Thank you, @andrielfn!

@DanielKehoe DanielKehoe mentioned this pull request Apr 11, 2014
Closed
@rafaelfranca
Copy link
Collaborator Author

We just released Simple Form 3.1.0.rc1 with Bootstrap 3 support. Please give a try.

http://blog.plataformatec.com.br/2014/04/bootstrap-3-support-for-simple-form/

@donnykurnia
Copy link

👍

tjgrathwell added a commit to railsbridge/bridge_troll that referenced this pull request May 30, 2014
@tjgrathwell
Bootstrap 3 WIP
8753eaf 
Things are generally working, except forms.

The viability of this branch probably depends on this PR getting finished:
heartcombo/simple_form-bootstrap#28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to the newest bootstrap version