Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build UMD module, point unpkg and jsdelivr to it. #148

Merged
merged 4 commits into from
Oct 28, 2019
Merged

Build UMD module, point unpkg and jsdelivr to it. #148

merged 4 commits into from
Oct 28, 2019

Conversation

tmcw
Copy link
Contributor

@tmcw tmcw commented Jun 6, 2019

Merge Checklist

馃敡 Issue(s) fixed:

馃毈 Smoke Test

  • Works in chrome
  • Works in firefox
  • Works in safari
  • Works in ie edge
  • Works in ie 11

馃殺 Merge

  • author crafted PR's title into release-worthy commit message.

This makes the browser build UMD by adding libraryTarget: umd, and points unpkg and jsdelivr to that build.

@tmcw
Copy link
Contributor Author

tmcw commented Sep 24, 2019

Any chance of getting this merged?

@jonvuri
Copy link
Contributor

jonvuri commented Oct 28, 2019

Verified again after remerge. Thank you for your contribution, @tmcw !

@jonvuri jonvuri merged commit 1a77115 into heavyai:master Oct 28, 2019
@jonvuri jonvuri mentioned this pull request Apr 10, 2020
Merged
domoritz referenced this pull request Apr 21, 2020
@jonvuri
[FE-10899] Fix old Observable imports (#181)
9557f33 
* Remove 'umd' target

* Remove unpkg / jsdelivr declarations

* Remove noop externals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonvuri jonvuri jonvuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make mapd-connector UMD to support importing rather than just global loading
2 participants
@tmcw @jonvuri